Should I dispose injected variable after assigment
I'm working on an active directory service class for my ASP.NET MVC web app. I use Ninject to IOC. I inject Forest to my class with the following manner.
private readonly Forest forest;
public ActiveDirectoryServices(Forest forest)
{
this.forest = forest;
}
In my NinjectWebCommon I use the following binding.
kernel.Bind<Forest>().ToSelf().InRequestScope();
After that, in my function I assign a new Forest to my injected forest variable.
this.forest = Forest.GetCurrentForest();
I know that, ninject handle object disposing if I use InRequestScope() binding, but is it true after a new reference assigment as well?
My question is, should I dispose the forest field in my class, or Ninject will handle it?
c# asp.net-mvc ninject ioc-container dispose
asked Nov 22 '18 at 15:19
EzayexEzayex
334
add a comment |
I'm working on an active directory service class for my ASP.NET MVC web app. I use Ninject to IOC. I inject Forest to my class with the following manner.
private readonly Forest forest;
public ActiveDirectoryServices(Forest forest)
{
this.forest = forest;
}
In my NinjectWebCommon I use the following binding.
kernel.Bind<Forest>().ToSelf().InRequestScope();
After that, in my function I assign a new Forest to my injected forest variable.
this.forest = Forest.GetCurrentForest();
I know that, ninject handle object disposing if I use InRequestScope() binding, but is it true after a new reference assigment as well?
My question is, should I dispose the forest field in my class, or Ninject will handle it?
c# asp.net-mvc ninject ioc-container dispose
asked Nov 22 '18 at 15:19
EzayexEzayex
334
1
the container will manage what it creates. If you create further instances after that, the container is unaware of those.
– Nkosi
Nov 22 '18 at 15:22
Thank you for your response. One more question. Can this cause memory leak? kernel.Bind<GlobalCatalog>().ToMethod(t => Forest.GetCurrentForest().FindGlobalCatalog());
– Ezayex
Nov 22 '18 at 15:42
1
You should share the code ofForest.GetCurrentForest()Is this a static method ? With a service locator call ?
– jbl
Nov 26 '18 at 10:51
add a comment |
I'm working on an active directory service class for my ASP.NET MVC web app. I use Ninject to IOC. I inject Forest to my class with the following manner.
private readonly Forest forest;
public ActiveDirectoryServices(Forest forest)
{
this.forest = forest;
}
In my NinjectWebCommon I use the following binding.
kernel.Bind<Forest>().ToSelf().InRequestScope();
After that, in my function I assign a new Forest to my injected forest variable.
this.forest = Forest.GetCurrentForest();
I know that, ninject handle object disposing if I use InRequestScope() binding, but is it true after a new reference assigment as well?
My question is, should I dispose the forest field in my class, or Ninject will handle it?
c# asp.net-mvc ninject ioc-container dispose
asked Nov 22 '18 at 15:19
EzayexEzayex
334
I'm working on an active directory service class for my ASP.NET MVC web app. I use Ninject to IOC. I inject Forest to my class with the following manner.
private readonly Forest forest;
public ActiveDirectoryServices(Forest forest)
{
this.forest = forest;
}
In my NinjectWebCommon I use the following binding.
kernel.Bind<Forest>().ToSelf().InRequestScope();
After that, in my function I assign a new Forest to my injected forest variable.
this.forest = Forest.GetCurrentForest();
I know that, ninject handle object disposing if I use InRequestScope() binding, but is it true after a new reference assigment as well?
My question is, should I dispose the forest field in my class, or Ninject will handle it?
c# asp.net-mvc ninject ioc-container dispose
c# asp.net-mvc ninject ioc-container dispose
asked Nov 22 '18 at 15:19
EzayexEzayex
334
asked Nov 22 '18 at 15:19
EzayexEzayex
334
asked Nov 22 '18 at 15:19
EzayexEzayex
334
asked Nov 22 '18 at 15:19
EzayexEzayex
334
asked Nov 22 '18 at 15:19
EzayexEzayex
334
334
1
the container will manage what it creates. If you create further instances after that, the container is unaware of those.
– Nkosi
Nov 22 '18 at 15:22
Thank you for your response. One more question. Can this cause memory leak? kernel.Bind<GlobalCatalog>().ToMethod(t => Forest.GetCurrentForest().FindGlobalCatalog());
– Ezayex
Nov 22 '18 at 15:42
1
You should share the code ofForest.GetCurrentForest()Is this a static method ? With a service locator call ?
– jbl
Nov 26 '18 at 10:51
add a comment |
1
the container will manage what it creates. If you create further instances after that, the container is unaware of those.
– Nkosi
Nov 22 '18 at 15:22
Thank you for your response. One more question. Can this cause memory leak? kernel.Bind<GlobalCatalog>().ToMethod(t => Forest.GetCurrentForest().FindGlobalCatalog());
– Ezayex
Nov 22 '18 at 15:42
1
You should share the code ofForest.GetCurrentForest()Is this a static method ? With a service locator call ?
– jbl
Nov 26 '18 at 10:51
1
1
the container will manage what it creates. If you create further instances after that, the container is unaware of those.
– Nkosi
Nov 22 '18 at 15:22
the container will manage what it creates. If you create further instances after that, the container is unaware of those.
– Nkosi
Nov 22 '18 at 15:22
Thank you for your response. One more question. Can this cause memory leak? kernel.Bind<GlobalCatalog>().ToMethod(t => Forest.GetCurrentForest().FindGlobalCatalog());
– Ezayex
Nov 22 '18 at 15:42
Thank you for your response. One more question. Can this cause memory leak? kernel.Bind<GlobalCatalog>().ToMethod(t => Forest.GetCurrentForest().FindGlobalCatalog());
– Ezayex
Nov 22 '18 at 15:42
1
1
You should share the code of
Forest.GetCurrentForest() Is this a static method ? With a service locator call ?– jbl
Nov 26 '18 at 10:51
You should share the code of
Forest.GetCurrentForest() Is this a static method ? With a service locator call ?– jbl
Nov 26 '18 at 10:51
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53433978%2fshould-i-dispose-injected-variable-after-assigment%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53433978%2fshould-i-dispose-injected-variable-after-assigment%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
the container will manage what it creates. If you create further instances after that, the container is unaware of those.
– Nkosi
Nov 22 '18 at 15:22
Thank you for your response. One more question. Can this cause memory leak? kernel.Bind<GlobalCatalog>().ToMethod(t => Forest.GetCurrentForest().FindGlobalCatalog());
– Ezayex
Nov 22 '18 at 15:42
1
You should share the code of
Forest.GetCurrentForest()Is this a static method ? With a service locator call ?– jbl
Nov 26 '18 at 10:51