Changing style properties inside 'click' events in multiple elements, using if statements












0














I have a simple todo list (<ul>). When user clicks <li>, the textDecoration property changes to "line-through". I want to be able to "undo" this somehow. Here's my code...



const lis = document.querySelectorAll('li');
lis.forEach(li => li.addEventListener('click', taskHandler));

function taskHandler(e) {
const li = e.target;
if ((li.style.textDecoration = 'none')) {
li.style.textDecoration = 'line-through';
console.log(`${li.textContent} is done`);
} else {
li.style.textDecoration = 'none';
console.log(`${li.textContent} is undone`);
}
}


My question is : why else block doesn't work ? And how do I fix this code ?



Thanks!










share|improve this question



























    0














    I have a simple todo list (<ul>). When user clicks <li>, the textDecoration property changes to "line-through". I want to be able to "undo" this somehow. Here's my code...



    const lis = document.querySelectorAll('li');
    lis.forEach(li => li.addEventListener('click', taskHandler));

    function taskHandler(e) {
    const li = e.target;
    if ((li.style.textDecoration = 'none')) {
    li.style.textDecoration = 'line-through';
    console.log(`${li.textContent} is done`);
    } else {
    li.style.textDecoration = 'none';
    console.log(`${li.textContent} is undone`);
    }
    }


    My question is : why else block doesn't work ? And how do I fix this code ?



    Thanks!










    share|improve this question

























      0












      0








      0







      I have a simple todo list (<ul>). When user clicks <li>, the textDecoration property changes to "line-through". I want to be able to "undo" this somehow. Here's my code...



      const lis = document.querySelectorAll('li');
      lis.forEach(li => li.addEventListener('click', taskHandler));

      function taskHandler(e) {
      const li = e.target;
      if ((li.style.textDecoration = 'none')) {
      li.style.textDecoration = 'line-through';
      console.log(`${li.textContent} is done`);
      } else {
      li.style.textDecoration = 'none';
      console.log(`${li.textContent} is undone`);
      }
      }


      My question is : why else block doesn't work ? And how do I fix this code ?



      Thanks!










      share|improve this question













      I have a simple todo list (<ul>). When user clicks <li>, the textDecoration property changes to "line-through". I want to be able to "undo" this somehow. Here's my code...



      const lis = document.querySelectorAll('li');
      lis.forEach(li => li.addEventListener('click', taskHandler));

      function taskHandler(e) {
      const li = e.target;
      if ((li.style.textDecoration = 'none')) {
      li.style.textDecoration = 'line-through';
      console.log(`${li.textContent} is done`);
      } else {
      li.style.textDecoration = 'none';
      console.log(`${li.textContent} is undone`);
      }
      }


      My question is : why else block doesn't work ? And how do I fix this code ?



      Thanks!







      javascript dom addeventlistener






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 21 '18 at 20:23









      max23701max23701

      172




      172
























          1 Answer
          1






          active

          oldest

          votes


















          0














          You are using a single = assignment operator to compare:



          if ((li.style.textDecoration = 'none'))


          Replace it with either == or ===:



          if ((li.style.textDecoration == 'none'))


          Also, not sure why the double (()) parenthesis?



          if (li.style.textDecoration === 'none')


          Should work fine.






          share|improve this answer





















            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "1"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53419948%2fchanging-style-properties-inside-click-events-in-multiple-elements-using-if-s%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            0














            You are using a single = assignment operator to compare:



            if ((li.style.textDecoration = 'none'))


            Replace it with either == or ===:



            if ((li.style.textDecoration == 'none'))


            Also, not sure why the double (()) parenthesis?



            if (li.style.textDecoration === 'none')


            Should work fine.






            share|improve this answer


























              0














              You are using a single = assignment operator to compare:



              if ((li.style.textDecoration = 'none'))


              Replace it with either == or ===:



              if ((li.style.textDecoration == 'none'))


              Also, not sure why the double (()) parenthesis?



              if (li.style.textDecoration === 'none')


              Should work fine.






              share|improve this answer
























                0












                0








                0






                You are using a single = assignment operator to compare:



                if ((li.style.textDecoration = 'none'))


                Replace it with either == or ===:



                if ((li.style.textDecoration == 'none'))


                Also, not sure why the double (()) parenthesis?



                if (li.style.textDecoration === 'none')


                Should work fine.






                share|improve this answer












                You are using a single = assignment operator to compare:



                if ((li.style.textDecoration = 'none'))


                Replace it with either == or ===:



                if ((li.style.textDecoration == 'none'))


                Also, not sure why the double (()) parenthesis?



                if (li.style.textDecoration === 'none')


                Should work fine.







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 21 '18 at 20:25









                NunchyNunchy

                825411




                825411






























                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.





                    Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


                    Please pay close attention to the following guidance:


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53419948%2fchanging-style-properties-inside-click-events-in-multiple-elements-using-if-s%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    404 Error Contact Form 7 ajax form submitting

                    How to know if a Active Directory user can login interactively

                    TypeError: fit_transform() missing 1 required positional argument: 'X'