Aho-Corasick algorithm (substrings search) implementation - performance issue











up vote
0
down vote

favorite












I solved this programming challenge where the goal is to give score to strings based on how much score certain substrings are worth (including repeating substrings).



Don't worry about what int values, valIndexes and the arguments of createTree() mean, just know that they have nothing to do with the search or organization of the data, they're only there for the score calculation.



The performance bottleneck of my code is interlink(), everything else works reasonably fast, any suggestions for how to fix this performance issue are greatly appreciated.



The input strings for createTree() and scan() are expected to contain only lowercase a-z characters.



class Tree {
public int values, valIndexes;
public Tree branches = new Tree[26];
public Tree link;

public static Tree createTree(String strs, int worth){
Tree mainTree = new Tree();
Tree currentNode;

for(int i = 0; i < strs.length; i++){
currentNode = mainTree;
for(int c = 0; c < strs[i].length(); c++){
int idx = strs[i].charAt(c) - 'a';
if(currentNode.branches[idx] == null)
currentNode.branches[idx] = new Tree();
currentNode = currentNode.branches[idx];
if(strs[i].length() == c + 1)
currentNode.addValue(worth[i], i);
}
}
mainTree.interlink(mainTree, "");

return mainTree;
}

public int scan(String str, int minIdx, int maxIdx){
int score = 0;
ArrayList<Tree> nodes = new ArrayList<Tree>();
for(int index = 0; index < str.length(); index++){

for(int e = 0; e < nodes.size(); e++) // advance nodes to next char
nodes.set(e, nodes.get(e).branches[str.charAt(index) - 'a']);

while(nodes.remove(null));
if(nodes.isEmpty()){ // if no nodes left, continue the search from first node
nodes.add(this.branches[str.charAt(index) - 'a']);
nodes.remove(null);
}
for(int e = 0; e < nodes.size(); e++){
Tree node = nodes.get(e);
if(node.link != null)
if(!nodes.contains(node.link))
nodes.add(node.link);

if(node.values != null)
for(int x = 0; x < node.values.length; x++)
if(node.valIndexes[x] >= minIdx && node.valIndexes[x] <= maxIdx)
score += node.values[x];
}
}
return score;
}

private void interlink(Tree mainTree, String path){
for(int i = 0; i < branches.length; i++){
if(branches[i] != null)
branches[i].interlink(mainTree, path + (char)(i + 'a'));
}
if(path.length() < 2) return;
Tree node;
for(int k = 1; k < path.length(); k++){
node = mainTree.getNode(path.substring(k));
if(node != null){
link = node;
break;
}
}
}

private Tree getNode(String str){
Tree node = this;
for(int c = 0; c < str.length(); c++){
node = node.branches[str.charAt(c) - 'a'];
if(node == null)
break;
}
return node;
}

private void addValue(int val, int idx){
// ... this part is irrelevant ...
}
}








share


























    up vote
    0
    down vote

    favorite












    I solved this programming challenge where the goal is to give score to strings based on how much score certain substrings are worth (including repeating substrings).



    Don't worry about what int values, valIndexes and the arguments of createTree() mean, just know that they have nothing to do with the search or organization of the data, they're only there for the score calculation.



    The performance bottleneck of my code is interlink(), everything else works reasonably fast, any suggestions for how to fix this performance issue are greatly appreciated.



    The input strings for createTree() and scan() are expected to contain only lowercase a-z characters.



    class Tree {
    public int values, valIndexes;
    public Tree branches = new Tree[26];
    public Tree link;

    public static Tree createTree(String strs, int worth){
    Tree mainTree = new Tree();
    Tree currentNode;

    for(int i = 0; i < strs.length; i++){
    currentNode = mainTree;
    for(int c = 0; c < strs[i].length(); c++){
    int idx = strs[i].charAt(c) - 'a';
    if(currentNode.branches[idx] == null)
    currentNode.branches[idx] = new Tree();
    currentNode = currentNode.branches[idx];
    if(strs[i].length() == c + 1)
    currentNode.addValue(worth[i], i);
    }
    }
    mainTree.interlink(mainTree, "");

    return mainTree;
    }

    public int scan(String str, int minIdx, int maxIdx){
    int score = 0;
    ArrayList<Tree> nodes = new ArrayList<Tree>();
    for(int index = 0; index < str.length(); index++){

    for(int e = 0; e < nodes.size(); e++) // advance nodes to next char
    nodes.set(e, nodes.get(e).branches[str.charAt(index) - 'a']);

    while(nodes.remove(null));
    if(nodes.isEmpty()){ // if no nodes left, continue the search from first node
    nodes.add(this.branches[str.charAt(index) - 'a']);
    nodes.remove(null);
    }
    for(int e = 0; e < nodes.size(); e++){
    Tree node = nodes.get(e);
    if(node.link != null)
    if(!nodes.contains(node.link))
    nodes.add(node.link);

    if(node.values != null)
    for(int x = 0; x < node.values.length; x++)
    if(node.valIndexes[x] >= minIdx && node.valIndexes[x] <= maxIdx)
    score += node.values[x];
    }
    }
    return score;
    }

    private void interlink(Tree mainTree, String path){
    for(int i = 0; i < branches.length; i++){
    if(branches[i] != null)
    branches[i].interlink(mainTree, path + (char)(i + 'a'));
    }
    if(path.length() < 2) return;
    Tree node;
    for(int k = 1; k < path.length(); k++){
    node = mainTree.getNode(path.substring(k));
    if(node != null){
    link = node;
    break;
    }
    }
    }

    private Tree getNode(String str){
    Tree node = this;
    for(int c = 0; c < str.length(); c++){
    node = node.branches[str.charAt(c) - 'a'];
    if(node == null)
    break;
    }
    return node;
    }

    private void addValue(int val, int idx){
    // ... this part is irrelevant ...
    }
    }








    share
























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      I solved this programming challenge where the goal is to give score to strings based on how much score certain substrings are worth (including repeating substrings).



      Don't worry about what int values, valIndexes and the arguments of createTree() mean, just know that they have nothing to do with the search or organization of the data, they're only there for the score calculation.



      The performance bottleneck of my code is interlink(), everything else works reasonably fast, any suggestions for how to fix this performance issue are greatly appreciated.



      The input strings for createTree() and scan() are expected to contain only lowercase a-z characters.



      class Tree {
      public int values, valIndexes;
      public Tree branches = new Tree[26];
      public Tree link;

      public static Tree createTree(String strs, int worth){
      Tree mainTree = new Tree();
      Tree currentNode;

      for(int i = 0; i < strs.length; i++){
      currentNode = mainTree;
      for(int c = 0; c < strs[i].length(); c++){
      int idx = strs[i].charAt(c) - 'a';
      if(currentNode.branches[idx] == null)
      currentNode.branches[idx] = new Tree();
      currentNode = currentNode.branches[idx];
      if(strs[i].length() == c + 1)
      currentNode.addValue(worth[i], i);
      }
      }
      mainTree.interlink(mainTree, "");

      return mainTree;
      }

      public int scan(String str, int minIdx, int maxIdx){
      int score = 0;
      ArrayList<Tree> nodes = new ArrayList<Tree>();
      for(int index = 0; index < str.length(); index++){

      for(int e = 0; e < nodes.size(); e++) // advance nodes to next char
      nodes.set(e, nodes.get(e).branches[str.charAt(index) - 'a']);

      while(nodes.remove(null));
      if(nodes.isEmpty()){ // if no nodes left, continue the search from first node
      nodes.add(this.branches[str.charAt(index) - 'a']);
      nodes.remove(null);
      }
      for(int e = 0; e < nodes.size(); e++){
      Tree node = nodes.get(e);
      if(node.link != null)
      if(!nodes.contains(node.link))
      nodes.add(node.link);

      if(node.values != null)
      for(int x = 0; x < node.values.length; x++)
      if(node.valIndexes[x] >= minIdx && node.valIndexes[x] <= maxIdx)
      score += node.values[x];
      }
      }
      return score;
      }

      private void interlink(Tree mainTree, String path){
      for(int i = 0; i < branches.length; i++){
      if(branches[i] != null)
      branches[i].interlink(mainTree, path + (char)(i + 'a'));
      }
      if(path.length() < 2) return;
      Tree node;
      for(int k = 1; k < path.length(); k++){
      node = mainTree.getNode(path.substring(k));
      if(node != null){
      link = node;
      break;
      }
      }
      }

      private Tree getNode(String str){
      Tree node = this;
      for(int c = 0; c < str.length(); c++){
      node = node.branches[str.charAt(c) - 'a'];
      if(node == null)
      break;
      }
      return node;
      }

      private void addValue(int val, int idx){
      // ... this part is irrelevant ...
      }
      }








      share













      I solved this programming challenge where the goal is to give score to strings based on how much score certain substrings are worth (including repeating substrings).



      Don't worry about what int values, valIndexes and the arguments of createTree() mean, just know that they have nothing to do with the search or organization of the data, they're only there for the score calculation.



      The performance bottleneck of my code is interlink(), everything else works reasonably fast, any suggestions for how to fix this performance issue are greatly appreciated.



      The input strings for createTree() and scan() are expected to contain only lowercase a-z characters.



      class Tree {
      public int values, valIndexes;
      public Tree branches = new Tree[26];
      public Tree link;

      public static Tree createTree(String strs, int worth){
      Tree mainTree = new Tree();
      Tree currentNode;

      for(int i = 0; i < strs.length; i++){
      currentNode = mainTree;
      for(int c = 0; c < strs[i].length(); c++){
      int idx = strs[i].charAt(c) - 'a';
      if(currentNode.branches[idx] == null)
      currentNode.branches[idx] = new Tree();
      currentNode = currentNode.branches[idx];
      if(strs[i].length() == c + 1)
      currentNode.addValue(worth[i], i);
      }
      }
      mainTree.interlink(mainTree, "");

      return mainTree;
      }

      public int scan(String str, int minIdx, int maxIdx){
      int score = 0;
      ArrayList<Tree> nodes = new ArrayList<Tree>();
      for(int index = 0; index < str.length(); index++){

      for(int e = 0; e < nodes.size(); e++) // advance nodes to next char
      nodes.set(e, nodes.get(e).branches[str.charAt(index) - 'a']);

      while(nodes.remove(null));
      if(nodes.isEmpty()){ // if no nodes left, continue the search from first node
      nodes.add(this.branches[str.charAt(index) - 'a']);
      nodes.remove(null);
      }
      for(int e = 0; e < nodes.size(); e++){
      Tree node = nodes.get(e);
      if(node.link != null)
      if(!nodes.contains(node.link))
      nodes.add(node.link);

      if(node.values != null)
      for(int x = 0; x < node.values.length; x++)
      if(node.valIndexes[x] >= minIdx && node.valIndexes[x] <= maxIdx)
      score += node.values[x];
      }
      }
      return score;
      }

      private void interlink(Tree mainTree, String path){
      for(int i = 0; i < branches.length; i++){
      if(branches[i] != null)
      branches[i].interlink(mainTree, path + (char)(i + 'a'));
      }
      if(path.length() < 2) return;
      Tree node;
      for(int k = 1; k < path.length(); k++){
      node = mainTree.getNode(path.substring(k));
      if(node != null){
      link = node;
      break;
      }
      }
      }

      private Tree getNode(String str){
      Tree node = this;
      for(int c = 0; c < str.length(); c++){
      node = node.branches[str.charAt(c) - 'a'];
      if(node == null)
      break;
      }
      return node;
      }

      private void addValue(int val, int idx){
      // ... this part is irrelevant ...
      }
      }






      java performance algorithm strings





      share












      share










      share



      share










      asked 7 mins ago









      potato

      18810




      18810



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208746%2faho-corasick-algorithm-substrings-search-implementation-performance-issue%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208746%2faho-corasick-algorithm-substrings-search-implementation-performance-issue%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'